-
Notifications
You must be signed in to change notification settings - Fork 35
Add Windows Emscripten build of xeus-cpp to ci #647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Windows Emscripten build of xeus-cpp to ci #647
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #647 +/- ##
=======================================
Coverage 79.83% 79.83%
=======================================
Files 9 9
Lines 3963 3963
=======================================
Hits 3164 3164
Misses 799 799 🚀 New features to boost your workflow:
|
bfac490
to
f5be4c6
Compare
For an Emscripten build of xeus-cpp to be possible on a Windows platform, the changes in this PR in xeus-cpp are required compiler-research/xeus-cpp#362 |
f5be4c6
to
b981887
Compare
b981887
to
8e8716f
Compare
8e8716f
to
c307b6f
Compare
c307b6f
to
62f4571
Compare
62f4571
to
58bfe95
Compare
This PR is ready for review |
ping @vgvassilev |
… Emscripten tests
…xeus cpp Emscripten tests" This reverts commit c8b23cc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
Please include a summary of changes, motivation and context for this PR.
This PR adds a Windows Emscripten build of xeus-cpp to ci
Fixes # (issue)
Type of change
Please tick all options which are relevant.
Testing
Please describe the test(s) that you added and ran to verify your changes.
Checklist